Construct DateTime objects with Local DateTimeKind#259
Merged
kelly-nelson merged 2 commits intoADAPT:developfrom Oct 30, 2025
Merged
Construct DateTime objects with Local DateTimeKind#259kelly-nelson merged 2 commits intoADAPT:developfrom
kelly-nelson merged 2 commits intoADAPT:developfrom
Conversation
Contributor
|
@strhea This looks good to me. ISO11783-10 is explicit that the time and date values in the binary records are in local time. |
Contributor
|
No objections on my end. |
kelly-nelson
added a commit
that referenced
this pull request
Nov 6, 2025
* Handle null representation code when examining workingdatas * Keep valuable operation information from device when possible * Two fixes for reading CNH Pro1200 Harvest data: - Stop forcing CategoryEnum.Variety to OperationTypeEnum.SowingAndPlanting (could be Harvesting) - In GetOperationTypeFromLoggingDevices, prefer a non-Unknown operation type * Construct DateTime objects with Local DateTimeKind (#259) * Construct DateTime objects with Local DateTimeKind * Consolidate "first day of 1980" fields --------- Co-authored-by: Eric Pohl <eric.pohl@corteva.com> * Only add boundary with spatial data (#261) * Adding FieldBoundary description from polygon designator if present * only add partfield boundary polygon if spartial data is present * Multiple partfield boundaries (#260) * Adding FieldBoundary description from polygon designator if present * Handle multiple boundaries for fields using the active or first boundary --------- Co-authored-by: Eric Pohl <eric.pohl@corteva.com> Co-authored-by: Stuart Rhea <stuart.rhea@live.com> Co-authored-by: Andrew Vardeman <andrew.vardeman.dev@gmail.com> Co-authored-by: Eric Pohl <31418444+ericpohl@users.noreply.github.com> Co-authored-by: Kenneth Lausdahl <lausdahl@users.noreply.github.com>
kelly-nelson
added a commit
that referenced
this pull request
Jan 8, 2026
* Handle null representation code when examining workingdatas * Keep valuable operation information from device when possible * Two fixes for reading CNH Pro1200 Harvest data: - Stop forcing CategoryEnum.Variety to OperationTypeEnum.SowingAndPlanting (could be Harvesting) - In GetOperationTypeFromLoggingDevices, prefer a non-Unknown operation type * Construct DateTime objects with Local DateTimeKind (#259) * Construct DateTime objects with Local DateTimeKind * Consolidate "first day of 1980" fields --------- Co-authored-by: Eric Pohl <eric.pohl@corteva.com> * Only add boundary with spatial data (#261) * Adding FieldBoundary description from polygon designator if present * only add partfield boundary polygon if spartial data is present * Multiple partfield boundaries (#260) * Adding FieldBoundary description from polygon designator if present * Handle multiple boundaries for fields using the active or first boundary * Fix ProductAllocation timestamp comparison issues (#263) * Construct DateTime objects with Local DateTimeKind * Consolidate "first day of 1980" fields * More messing with timezones * Cleanup --------- Co-authored-by: Eric Pohl <eric.pohl@corteva.com> --------- Co-authored-by: Eric Pohl <eric.pohl@corteva.com> Co-authored-by: Stuart Rhea <stuart.rhea@live.com> Co-authored-by: Andrew Vardeman <andrew.vardeman.dev@gmail.com> Co-authored-by: Eric Pohl <31418444+ericpohl@users.noreply.github.com> Co-authored-by: Kenneth Lausdahl <lausdahl@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ADAPT framework documentation clearly states that date/times should be expressed in local time, but currently they show as DateTimeKind=Unspecified. Remove this ambiguity by explicitly setting
ISOTimeLogDateTimeobjects to Local time. This is done by settingDateTimeKindfor the readonly fieldTimeLogMapper._firstDayOf1980(consolidated from two separate fields in theBinaryReaderandBinaryWriterinner classes).